-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(superset-ui-core): add feature flag for the analogous colors #19987
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19987 +/- ##
==========================================
- Coverage 66.46% 66.41% -0.06%
==========================================
Files 1721 1719 -2
Lines 64517 64346 -171
Branches 6807 6723 -84
==========================================
- Hits 42879 42733 -146
+ Misses 19906 19902 -4
+ Partials 1732 1711 -21
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up FEATURE_USE_ANALAGOUS_COLORS=false |
@geido Ephemeral environment spinning up at http://54.185.1.3:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT!
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
This PR adds a FEATURE_FLAG for
USE_ANALAGOUS_COLORS
which, when enabled, would act as it does today. If you turn it off, it would simply loop through the palette colors repeatedly. Default is True. refer to #19038 (comment).BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION