fix(modal): add primary button loading state to modals #20018
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
AddDatasetModal
, while a dataset is being saved, the primary "Add" button is not disabled - allowing user to click on the "Add" button multiple times while the resource is being saved. This allows the user to add duplicate datasetsprimaryButtonLoading
prop to theModal
componentAddDatasetModal
passes a loading prop to theModal
component while the resource creation is loadingBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-05-10.at.12.53.15.PM.mov
TESTING INSTRUCTIONS
superset.datasets.api.py
in the POST function on the\
path (dataset creation path)ADDITIONAL INFORMATION