chore: Fix and enhance Applitools workflows #20071
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20071 +/- ##
=======================================
Coverage 66.37% 66.37%
=======================================
Files 1715 1715
Lines 64179 64179
Branches 6753 6753
=======================================
Hits 42602 42602
Misses 19859 19859
Partials 1718 1718
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| runs-on: ubuntu-latest | ||
| runs-on: ubuntu-20.04 |
There was a problem hiding this comment.
We should probably pin all workflows to ubuntu-20.04 (let's do it in a follow-up)
| - uses: actions/checkout@v3 | ||
| - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )" | ||
| uses: actions/checkout@v3 |
There was a problem hiding this comment.
bycatch: we should probably also bump all actions/checkout@v2 to actions/checkout@v3 (also in that same follow-up).
| - name: Set up Node.js | ||
| uses: actions/setup-node@v3.1.1 | ||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v2 |
There was a problem hiding this comment.
Same here - I'd rather use actions/setup-node@v3 as it uses Node 16 (https://github.com/actions/setup-node/releases/tag/v3.0.0) - any reason why we're tagging v2?
There was a problem hiding this comment.
I think this was just a copy and paste error on my side and also because most of the other actions are using v2. Let me do this in the follow-up as well so I can test all these changes you suggested locally.
* Enhance workflow * Fix failing workflow * Enhance storybook with cached-dependencies
* Enhance workflow * Fix failing workflow * Enhance storybook with cached-dependencies
mistercrunch
added
🏷️ bot
SUMMARY
This PR enhances the Applitools Storybook workflow to run cached-dependencies. Also, it fixes an issue with the Applitools Cypress workflow not running in CI.
ADDITIONAL INFORMATION