fix: translating variables #20080

aehanno · 2022-05-16T14:21:51Z

SUMMARY

translating variables

ADDITIONAL INFORMATION

Fixes #20060

aehanno · 2022-06-06T15:55:46Z

@villebro , i will be glad to discuss with you about variable translation.

Without adding translation on those varaibles, we have any translation on the second part of those sentence
I only find this solution and after testing, I didn't catch error with this correction

I understand your worries about that, and i will be glad to understand any other solution to solve that problem

villebro · 2022-06-15T07:49:01Z

@aehanno can you show a before and after of these changes? I'd like to understand how these translations are being picked up

codecov · 2022-06-15T08:26:32Z

Codecov Report

Merging #20080 (afb2301) into master (17fbb2d) will decrease coverage by 11.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #20080       +/-   ##
===========================================
- Coverage   67.47%   56.44%   -11.04%     
===========================================
  Files        1880     1880               
  Lines       72283    72282        -1     
  Branches     7881     7880        -1     
===========================================
- Hits        48772    40797     -7975     
- Misses      21486    29460     +7974     
  Partials     2025     2025

Flag	Coverage Δ
hive	`52.73% <ø> (ø)`
mysql	`?`
postgres	`?`
presto	`52.62% <ø> (ø)`
python	`59.18% <ø> (-22.95%)`	⬇️
sqlite	`?`
unit	`52.46% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ivot-table/src/react-pivottable/TableRenderers.jsx	`0.00% <ø> (ø)`
.../components/FiltersBadge/FilterIndicator/index.tsx	`87.50% <ø> (ø)`
...t-frontend/src/dashboard/components/SliceAdder.jsx	`60.27% <ø> (ø)`
...nts/controls/DateFilterControl/DateFilterLabel.tsx	`61.45% <ø> (-0.40%)`	⬇️
superset/utils/dashboard_import_export.py	`0.00% <0.00%> (-100.00%)`	⬇️
superset/tags/core.py	`4.54% <0.00%> (-95.46%)`	⬇️
superset/key_value/commands/update.py	`0.00% <0.00%> (-90.91%)`	⬇️
superset/key_value/commands/delete.py	`0.00% <0.00%> (-87.88%)`	⬇️
superset/key_value/commands/delete_expired.py	`0.00% <0.00%> (-84.00%)`	⬇️
superset/dashboards/commands/importers/v0.py	`15.62% <0.00%> (-76.25%)`	⬇️
... and 288 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

aehanno · 2022-06-15T13:49:55Z

@aehanno can you show a before and after of these changes? I'd like to understand how these translations are being picked up

Hey @villebro, yes of course, I can show you an exemple.
It's in dashboard edition in charts tab.

For this one, I added modification in SliceAdder.jsx file,

There is before my correction label: t('Sort by %s', label),

And this one is after my correction label: t('Sort by %s', t(label)),

We can see the second part is well translate in the second image

# Conflicts: # superset/translations/fr/LC_MESSAGES/messages.json

rusackas · 2022-12-07T23:38:11Z

superset-frontend/src/dashboard/components/FiltersBadge/FilterIndicator/index.tsx

@@ -51,7 +52,7 @@ const FilterIndicator: FC<IndicatorProps> = ({
 {name}
 {resultValue ? ': ' : ''}
 </Title>
- <FilterValue>{resultValue}</FilterValue>
+ <FilterValue>{t(resultValue)}</FilterValue>


This seems like something that might not have a static/expected value, is that correct?

Hey in my understanding of the translation framework, it does static analysis of the code to find translatable strings, it only works on constants not on variables.

rusackas · 2022-12-07T23:38:55Z

superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx

@@ -314,7 +314,7 @@ export default function DateFilterLabel(props: DateFilterControlProps) {
 <Divider />
 <div>
 <div className="section-title">{t('Actual time range')}</div>
- {validTimeRange && <div>{evalResponse}</div>}
+ {validTimeRange && <div>{t(evalResponse)}</div>}


Same here... is this something we would expect to have in the translation files, or is it a more dynamic value (as it sounds, based on the name)

Yes, it's a date or it's write 'No filter', so I think in fact that will juste translate 'no filter' and don't touch to other result

Maybe it's worth putting a little ternary condition or similar in there, e.g. evalResponse = 'no filter' ? t('no filter') : evalResponse? Or maybe there's somewhere further upstream in the code that's more appropriate to the the translation?

rusackas · 2022-12-07T23:39:40Z

superset/translations/fr/LC_MESSAGES/messages.json

+ "Sum as Fraction of Columns": ["Somme comme fraction des colonnes"],
+ "Count as Fraction of Total": ["Décompte comme fraction du total"],
+ "Count as Fraction of Rows": ["Décompte comme fraction des lignes"],
+ "Count as Fraction of Columns": ["Décompte comme fraction des colonnes"]


@mistercrunch do the above translations look correct to you?

rusackas · 2023-01-31T00:12:41Z

Looks like this needs a rebase. There have been some other PRs recently adding translations as well, so I hope it's not too painful.

We also still need some validation of the language itself, if @mistercrunch or anyone else that speaks French has time to scope it out :)

rusackas · 2024-02-09T20:17:02Z

Sadly, it looks like this never passed, CI, never got validation of the translated strings, and now is in need of a rebase again. @aehanno would you mind doing a rebase, and we can try again to get this across the finish line? Thanks!

mistercrunch · 2024-02-12T17:05:23Z

superset/translations/fr/LC_MESSAGES/messages.json

- "No matching records found": ["Aucun résultat trouvé"]
+ "No matching records found": ["Aucun résultat trouvé"],
+ "Trend": ["Tendance"],
+ "Total (Count)": ["Total (Somme)"],


Count != Somme
more like "Compte" ou "Nombre"

mistercrunch · 2024-02-12T17:06:55Z

superset/translations/fr/LC_MESSAGES/messages.json

@@ -3877,7 +3877,27 @@
 ],
 "Scope": ["Périmètre"],
 "Dependent on": ["Dépend de"],
- "No matching records found": ["Aucun résultat trouvé"]
+ "No matching records found": ["Aucun résultat trouvé"],


isn't the .json file generated here? shouldn't this be in the .po file?

Yes indeed! I thought that was covered in this PR, but that doesn't seem to be the case.

fix : translating variables

c2af98d

pull-request-size bot added the size/XS label May 16, 2022

wrong position of translation

320ce63

aehanno mentioned this pull request May 16, 2022

fix: Add french translation missing #20061

Merged

villebro requested a review from zhaoyongjie June 15, 2022 07:47

aehanno changed the title ~~fix : translating variables~~ fix: translating variables Jun 15, 2022

aehanno added 2 commits July 13, 2022 09:23

fix : correction display time in dashboard filter

e346f30

fix : fix trad in tablerenderers

593d010

pull-request-size bot added size/M and removed size/XS labels Jul 14, 2022

aehanno added 7 commits July 14, 2022 11:40

fix

74c6634

Merge branch 'master' into translating-variables

09e1a08

# Conflicts: # superset/translations/fr/LC_MESSAGES/messages.json

fix prettier

47760f6

fix : try to not translate variable

c873741

fix : try to not translate variable

e6ff381

fix : run prettier

769d92a

Merge branch 'master' into translating-variables

c801c1d

artemonsh mentioned this pull request Oct 12, 2022

No translation for ControlPanel because of react-pivottable lack of flexibility #21783

Closed

3 tasks

rusackas reviewed Dec 7, 2022

View reviewed changes

aehanno and others added 3 commits February 13, 2023 10:04

Merge branch 'master' into translating-variables

367dd93

merge

6ecc73d

merge

afb2301

mistercrunch reviewed Feb 12, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: translating variables #20080

fix: translating variables #20080

aehanno commented May 16, 2022

aehanno commented Jun 6, 2022

villebro commented Jun 15, 2022

codecov bot commented Jun 15, 2022 •

edited

Loading

aehanno commented Jun 15, 2022

rusackas Dec 7, 2022

mistercrunch Feb 12, 2024

rusackas Dec 7, 2022

aehanno Dec 8, 2022

rusackas Dec 8, 2022

rusackas Dec 7, 2022

rusackas commented Jan 31, 2023

rusackas commented Feb 9, 2024

mistercrunch Feb 12, 2024

mistercrunch Feb 12, 2024

rusackas Feb 12, 2024

fix: translating variables #20080

Are you sure you want to change the base?

fix: translating variables #20080

Conversation

aehanno commented May 16, 2022

SUMMARY

ADDITIONAL INFORMATION

aehanno commented Jun 6, 2022

villebro commented Jun 15, 2022

codecov bot commented Jun 15, 2022 • edited Loading

Codecov Report

aehanno commented Jun 15, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rusackas commented Jan 31, 2023

rusackas commented Feb 9, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jun 15, 2022 •

edited

Loading