Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "feat(explore): Show confirmation modal if user exits Explore without saving changes (#19993) #20092

Merged
merged 1 commit into from
May 17, 2022

Conversation

kgabryje
Copy link
Member

SUMMARY

We found some bugs in #19993. Let's revert for now and reopen when they're fixed.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@kgabryje kgabryje changed the title Revert "feat(explore): Show confirmation modal if user exits Explore without saving changes (#19993) fix: Revert "feat(explore): Show confirmation modal if user exits Explore without saving changes (#19993) May 17, 2022
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #20092 (0fb418a) into master (e69f629) will increase coverage by 0.00%.
The diff coverage is 90.90%.

@@           Coverage Diff           @@
##           master   #20092   +/-   ##
=======================================
  Coverage   66.45%   66.46%           
=======================================
  Files        1721     1721           
  Lines       64481    64463   -18     
  Branches     6796     6794    -2     
=======================================
- Hits        42854    42844   -10     
+ Misses      19897    19891    -6     
+ Partials     1730     1728    -2     
Flag Coverage Δ
javascript 51.35% <90.90%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../explore/components/ExploreViewContainer/index.jsx 52.57% <ø> (+0.46%) ⬆️
...rset-frontend/src/explore/exploreUtils/formData.ts 85.71% <ø> (-3.18%) ⬇️
...-frontend/src/components/AlteredSliceTag/index.jsx 88.57% <90.90%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e69f629...0fb418a. Read the comment docs.

@kgabryje kgabryje merged commit 9cdaa28 into apache:master May 17, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants