fix: Add cypress test for report page direct link issue #20099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegomedina248
approved these changes
May 17, 2022
stephenLYZ
reviewed
May 17, 2022
superset-frontend/cypress-base/cypress/integration/alerts_and_reports/alert_report.helper.ts
Show resolved
Hide resolved
| @@ -0,0 +1,26 @@ | |||
| import { ALERT_LIST } from './alert_report.helper'; | |||
| @@ -0,0 +1,26 @@ | |||
| import { REPORT_LIST } from './alert_report.helper'; | |||
codemaster08240328
changed the title
Codecov Report
@@ Coverage Diff @@
## master #20099 +/- ##
=======================================
Coverage 66.45% 66.46%
=======================================
Files 1721 1721
Lines 64479 64463 -16
Branches 6795 6794 -1
=======================================
- Hits 42852 42844 -8
+ Misses 19897 19891 -6
+ Partials 1730 1728 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
* add cypress test for report page direct link issue * add licence
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This issue keeps being appeared several times, need to add test not to break it again.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION