-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Query.columns for bootstrap_data #20134
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20134 +/- ##
===========================================
- Coverage 66.47% 54.55% -11.92%
===========================================
Files 1721 1721
Lines 64477 64500 +23
Branches 6795 6805 +10
===========================================
- Hits 42858 35187 -7671
- Misses 19891 27581 +7690
- Partials 1728 1732 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
d1358dd
to
433d4d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@@ -905,6 +908,7 @@ def explore( | |||
"user": bootstrap_user_data(g.user, include_perms=True), | |||
"forced_height": request.args.get("height"), | |||
"common": common_bootstrap_payload(), | |||
"columns": columns, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current columns are passed in to the datasource object. For easier lookup, do you think we can keep the same structure for queries, instead of having to look in two different places?
SUMMARY
Added logic to send Query.columns to explore if the datasource is a Query.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION