chore(data-table): make formatted dttm the default #20140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
commented
May 20, 2022
Comment on lines
-138
to
-144
| hook.result.current.forEach((col: JsonObject) => { | ||
| expect(col.Cell({ value: newData[0].col01 })).toBe(BOOL_TRUE_DISPLAY); | ||
| expect(col.Cell({ value: newData[0].col02 })).toBe(BOOL_FALSE_DISPLAY); | ||
| expect(col.Cell({ value: newData[0].col03 })).toBe('secret'); | ||
| expect(col.Cell({ value: newData[0][asciiKey] })).toBe(asciiKey); | ||
| expect(col.Cell({ value: newData[0][unicodeKey] })).toBe(unicodeKey); | ||
| }); |
There was a problem hiding this comment.
This logic was incorrect, and caused each cell formatter to process each value on the row
Codecov Report
@@ Coverage Diff @@
## master #20140 +/- ##
=======================================
Coverage 66.45% 66.45%
=======================================
Files 1721 1721
Lines 64497 64500 +3
Branches 6805 6806 +1
=======================================
+ Hits 42860 42863 +3
Misses 19905 19905
Partials 1732 1732
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
commented
May 20, 2022
| { | ||
| col01: true, | ||
| col02: false, | ||
| col03: 'secret', |
There was a problem hiding this comment.
The data API never returns "suprise" values for columns that aren't listed in colnames, hence we don't need to test for this edge case.
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR changes time formatting to be the default for temporal columns (previously defaulted to showing the original value). This is done by replacing the
timeFormattedColumnswithoriginalFormattedTimeColumnsthroughout the codebase, meaning if a dataset doesn't have defined values for them, they will default to using the time formatter.In addition to changing the default, the
DataTableTemporalHeaderCellwill only be shown for tables where the first cell value isn't a string value. This is because some databases like Druid and SQLite return temporal data in string format, which causes the time formatter to convert the timestamp to UTC, causing x hours of offset. (For Finland, this would show all dates to show as 10 pm the previous day).AFTER
Now the formatted option is the new default:
For datasets that have string-based temporal data, the regular non-temporal header is shown (screenshot from SQLite). Notice the first column
dswhich doesn't have the formatting cog:TESTING INSTRUCTIONS
ADDITIONAL INFORMATION