Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Implement global header in Dashboard #20146

Merged
merged 9 commits into from
May 25, 2022
Merged

chore: Implement global header in Dashboard #20146

merged 9 commits into from
May 25, 2022

Conversation

geido
Copy link
Member

@geido geido commented May 20, 2022 •
edited
Loading

SUMMARY

This PR implements the global header in the Dashboard introduced in this PR #20044

BEFORE

Slack.Dashboard.1.mp4

AFTER

Slack.Dashboard.mp4

TESTING INSTRUCTIONS

  1. Make sure all the existing functionalities of the Dashboard work as intended

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido geido requested a review from kgabryje May 20, 2022 15:19
@geido geido marked this pull request as ready for review May 20, 2022 15:19
@kgabryje
Copy link
Member

kgabryje commented May 20, 2022 •
edited
Loading

I think spacing between Discard and Save buttons is a bit off (Discard button has unnecessary 5px right margin). Also, the save button is wider in the designs

image

@codecov
Copy link

codecov bot commented May 20, 2022 •
edited
Loading

Codecov Report

Merging #20146 (dab31e7) into master (27cccd1) will decrease coverage by 0.02%.
The diff coverage is 88.09%.

@@            Coverage Diff             @@
##           master   #20146      +/-   ##
==========================================
- Coverage   66.46%   66.44%   -0.03%     
==========================================
  Files        1721     1721              
  Lines       64467    64507      +40     
  Branches     6795     6818      +23     
==========================================
+ Hits        42847    42860      +13     
- Misses      19892    19914      +22     
- Partials     1728     1733       +5
Flag Coverage Δ
javascript 51.33% <88.09%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Icons/index.tsx 100.00% <ø> (ø)
...end/src/components/PageHeaderWithActions/index.tsx 90.00% <ø> (ø)
...ponents/ReportModal/HeaderReportDropdown/index.tsx 68.00% <ø> (-1.34%) ⬇️
...dashboard/components/menu/ShareMenuItems/index.tsx 90.00% <ø> (ø)
.../components/Header/HeaderActionsDropdown/index.jsx 68.33% <76.92%> (-3.34%) ⬇️
...frontend/src/dashboard/components/Header/index.jsx 59.39% <92.30%> (+2.59%) ⬆️
...tend/src/components/DynamicEditableTitle/index.tsx 75.92% <100.00%> (+0.92%) ⬆️
.../explore/components/ExploreViewContainer/index.jsx 52.02% <100.00%> (-0.55%) ⬇️
.../plugin-chart-echarts/src/MixedTimeseries/index.ts 25.00% <0.00%> (-25.00%) ⬇️
...tend/plugins/plugin-chart-echarts/src/controls.tsx 56.66% <0.00%> (-17.25%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27cccd1...dab31e7. Read the comment docs.

@geido geido requested a review from kgabryje May 23, 2022 09:05
@kgabryje
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@kgabryje Ephemeral environment spinning up at http://35.89.168.212:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@kgabryje
Copy link
Member

I think that Discard and Save buttons should be 2px higher - they're 30px, while on the designs they are 32. Because of that they look misaligned with the menu dropdown button. On the other hand, the "Edit dashboard" button has correct height - 32px.

image

@kgabryje
Copy link
Member

Can we use 8px right margin using theme instead of m-r-5 class that sets 5px margin?
image

@zhaoyongjie zhaoyongjie self-requested a review May 23, 2022 12:34
zhaoyongjie
zhaoyongjie approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

stephenLYZ
stephenLYZ approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE WORK! LGTM!

kgabryje
kgabryje approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geido geido merged commit 3a4176a into apache:master May 25, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@geido @philipher29
chore: Implement global header in Dashboard (apache#20146)
cea81ec 
* Add gloal header

* Reimplement report dropdown

* Update unit tests

* Clean up

* Clean up

* Remove unused import

* Update Cypress

* Update Cypress save dashboard test

* Fix spacing
@mistercrunch mistercrunch added the 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje kgabryje approved these changes

@stephenLYZ stephenLYZ stephenLYZ approved these changes

@zhaoyongjie zhaoyongjie zhaoyongjie approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@geido @kgabryje @zhaoyongjie @stephenLYZ @mistercrunch