Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: filter undefined operators #20157

Merged
merged 1 commit into from
May 23, 2022

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

Remove undefined post-processing operators after build query.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie zhaoyongjie marked this pull request as ready for review May 23, 2022 08:42
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #20157 (d84ef57) into master (0bcc21b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #20157   +/-   ##
=======================================
  Coverage   66.46%   66.46%           
=======================================
  Files        1721     1721           
  Lines       64512    64517    +5     
  Branches     6806     6807    +1     
=======================================
+ Hits        42875    42879    +4     
- Misses      19905    19906    +1     
  Partials     1732     1732           
Flag Coverage Δ
javascript 51.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in-chart-echarts/src/MixedTimeseries/buildQuery.ts 100.00% <ø> (ø)
.../plugin-chart-echarts/src/Timeseries/buildQuery.ts 66.66% <ø> (ø)
...es/superset-ui-core/src/query/buildQueryContext.ts 100.00% <100.00%> (ø)
superset-frontend/src/explore/fixtures.tsx 66.66% <0.00%> (ø)
...perset-frontend/src/utils/getControlsForVizType.js 92.85% <0.00%> (ø)
...ntend/src/explore/controlUtils/getControlConfig.ts 100.00% <0.00%> (ø)
...plugins/legacy-plugin-chart-heatmap/src/Heatmap.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bcc21b...d84ef57. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the cleanup 👍

@zhaoyongjie zhaoyongjie merged commit d7e3ac3 into apache:master May 23, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants