feat(explore): Add empty state to annotations #20160
Conversation
kgabryje
changed the title
There was a problem hiding this comment.
Very nice, the previous behavior caused a lot of clicking back and forth, this greatly clarifies + simplifies the flow 👍 LGTM (the comment is more thinking about better ways of translating React components where the translation text needs to flow into its children)
| {t('Add an annotation layer')}{' '} | ||
| <a | ||
| href="/annotationlayermodelview/list" | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| > | ||
| {t('here')} | ||
| </a> |
There was a problem hiding this comment.
This isn't the only place where we have this type of translation logic, but splitting up a translation like this can be problematic for languages that have different sentence structure/order than English. But since I don't have a better proposal at this time we can surely live with this. But maybe there's a more modern translation library out there that more natively supports these types of Reacty-y use cases better.
There was a problem hiding this comment.
..aaand some quick googling turned up this: https://react.i18next.com/
There was a problem hiding this comment.
Good point. I'm not very familiar with the translation logic. Do you think it'd be a big project to switch to using this library?
Codecov Report
@@ Coverage Diff @@
## master #20160 +/- ##
==========================================
- Coverage 66.47% 66.46% -0.02%
==========================================
Files 1727 1721 -6
Lines 64724 64524 -200
Branches 6822 6811 -11
==========================================
- Hits 43024 42884 -140
+ Misses 19969 19907 -62
- Partials 1731 1733 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kgabryje
force-pushed
the
feat/annotations-empty-state
branch
from
253075f
to
48b3e5e
Compare
* feat(explore): Add empty state to annotations * Set line height for small empty state description * Simplify code
mistercrunch
added
🏷️ bot
SUMMARY
When there's no annotation sources available, display an empty state with a link to annotation layers view.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
CC @kasiazjc