fix(charts list): do not trigger ListViewError exception for anonymous user #20171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20171 +/- ##
==========================================
- Coverage 66.46% 66.43% -0.03%
==========================================
Files 1721 1723 +2
Lines 64521 64627 +106
Branches 6811 6829 +18
==========================================
+ Hits 42882 42935 +53
- Misses 19906 19960 +54
+ Partials 1733 1732 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
stephenLYZ
approved these changes
Jun 2, 2022
| userId, | ||
| refreshData, | ||
| saveFavoriteStatus, | ||
| // userKey, |
There was a problem hiding this comment.
Can we remove this unused code?
There was a problem hiding this comment.
Yes, I tested the chart list successfully (connected and anonymously); initial commit was amended minus the above chunk: 0bb05c4
trepmag
force-pushed
the
fix/charts_list_for_anonymous_users
branch
from
8ffa4eb
to
0bb05c4
Compare
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR is a follow up for issue #18210 which fixes charts list, while the first PR #19409 fixes the dashboards list.
Note well: this PR is a copy/past of @dudasaron PR #19409 for dashboards list, for which, I must admit, I don't master each changes...
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TESTING INSTRUCTIONS
Was tested on current master (b746e6f): visit the charts list as anonymous user...
ADDITIONAL INFORMATION