Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes issue where results panel height was incorrect [sc-49045] #20204

Conversation

eric-briscoe
Copy link
Contributor

This commit fixes a dynamic height assignment issue where the SQL Editor results panel would be clipped offscreen and user could not see bottom of results, the height got assigned to zero after toggling online, then offline, and height would be calculated wrong if the result set rows returned message above the results table was long enough for a line wrap.

SUMMARY

This PR fixes a dynamic height assignment issue where the SQL Editor results panel would be clipped offscreen and user could not see bottom of results, the height got assigned to zero after toggling online, then offline, and height would be calculated wrong if the result set rows returned message above the results table was long enough for a line wrap.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before Fix:
https://drive.google.com/file/d/1A0mMm-1HoO2ol-65Tv3ENpv1e1tMRg_g/view?usp=sharing

After Fix:
https://drive.google.com/file/d/1Y7GFbvo_hfEsl6hhD1WI6if6m0BA128C/view

TESTING INSTRUCTIONS

1.Open SQL Editor
2.Create new or use existing Query
3. Click "RUN"
4. You should see the results under the SQL Editor
5. In Chrome Developer tools -> Network -> Change network speed from "No throttling" to "Offline"
6. Click "RUN"
7. Wait for UI to show the red "Offline" pill
8. In Chrome Developer tools -> Network -> Change network speed from "Offline" to "No throttling"
9. Click "RUN"

Expected results (with fix)
After re-enabling the network connection and clicking run you should see query results again

Actual results (before fix)
The results panel is hidden with a CSS height of zero and will stay hidden until the browser is refreshed, or the user toggles between open Sql Editor tabs

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

This commit fixes a dynamic height assignment issue where the SQL Editor results panel would be clipped offscreen and user could not see bottom of results, the height got assigned to zero after toggling online, then offline, and height would be calculated wrong if the result set rows returned message above the results table was long enough for a line wrap.
@eric-briscoe eric-briscoe changed the title bug: Fixes issue where results panel height was incorrect [sc-49045] fix: Fixes issue where results panel height was incorrect [sc-49045] May 26, 2022
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #20204 (82f2f1e) into master (7a2eb8b) will increase coverage by 0.00%.
The diff coverage is 71.42%.

@@           Coverage Diff           @@
##           master   #20204   +/-   ##
=======================================
  Coverage   66.46%   66.47%           
=======================================
  Files        1727     1727           
  Lines       64721    64729    +8     
  Branches     6823     6824    +1     
=======================================
+ Hits        43019    43026    +7     
  Misses      19970    19970           
- Partials     1732     1733    +1     
Flag Coverage Δ
javascript 51.34% <71.42%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/SqlLab/components/ResultSet/index.tsx 51.65% <66.66%> (+1.16%) ⬆️
...frontend/src/SqlLab/components/SouthPane/index.tsx 66.66% <100.00%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a2eb8b...82f2f1e. Read the comment docs.

Copy link
Member

@hughhhh hughhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@zhaoyongjie zhaoyongjie merged commit e5f2631 into apache:master Jun 2, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
…he#20204)

This commit fixes a dynamic height assignment issue where the SQL Editor results panel would be clipped offscreen and user could not see bottom of results, the height got assigned to zero after toggling online, then offline, and height would be calculated wrong if the result set rows returned message above the results table was long enough for a line wrap.
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants