Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy-plugin-chart-sunburst): linear color scheme not work when secondary metric is provided #20221

Merged
merged 1 commit into from
May 31, 2022

Conversation

stephenLYZ
Copy link
Member

SUMMARY

In the sunburst chart, there is a color policy that normally uses the category color, but when second metric value is provided and is different from the first metric value, the gradient color is used. The category color was previously introduced in color consistency, but the gradient failed in the scenario described above, so we fix it here.

  • Normally, category colors are used and the color scheme control is displayed
  • When the second metric value is provided and differs from the first metric value, the gradient color is used and the gradient color control is displayed

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

after

2022-05-31.12.03.50.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #20221 (8cb8f5a) into master (c8fe518) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #20221      +/-   ##
==========================================
- Coverage   66.47%   66.46%   -0.01%     
==========================================
  Files        1727     1727              
  Lines       64724    64728       +4     
  Branches     6822     6824       +2     
==========================================
  Hits        43024    43024              
- Misses      19969    19973       +4     
  Partials     1731     1731              
Flag Coverage Δ
javascript 51.33% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ugins/legacy-plugin-chart-sunburst/src/Sunburst.js 0.00% <0.00%> (ø)
...s/legacy-plugin-chart-sunburst/src/controlPanel.ts 20.00% <0.00%> (-80.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8fe518...8cb8f5a. Read the comment docs.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codes LGTM, but when I tested locally, I faced a different error after applying multiple columns(Hierarchy). Maybe a separate PR is needed.

image

@stephenLYZ stephenLYZ merged commit 9646591 into apache:master May 31, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants