docs(contribute): update compatible Python versions in local environment setup instructions #20260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschutho
requested changes
Jun 15, 2022
CONTRIBUTING.md
Outdated
| @@ -413,7 +413,7 @@ For example, the image referenced above actually lives in `superset-frontend/src | |||
| Make sure your machine meets the [OS dependencies](https://superset.apache.org/docs/installation/installing-superset-from-scratch#os-dependencies) before following these steps. | |||
| You also need to install MySQL or [MariaDB](https://mariadb.com/downloads). | |||
|
|
|||
| Ensure that you are using Python version 3.7 or 3.8, then proceed with: | |||
| Ensure that you are using Python version 3.8 or higher, then proceed with: | |||
There was a problem hiding this comment.
I believe we only support 3.8 or 3.9 right now. Can we update this? Thank you!
akshatsri
pushed a commit
to charan1314/superset
that referenced
this pull request
Jul 19, 2022
…ent setup instructions (apache#20260) * Remove incompatible Python 3.7 from local env setup docs * Ensure Python 3.8 or 3.9 Co-authored-by: Diego Martin <diego.martin@indigitall.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
At the moment, contributors are instructed to use to ensure they're using Python 3.7 or 3.8 when setting up the local development environment. However, Python 3.7 is no longer compatible with apache-superset, and the pip install fails when using this version of Python.
A quick check on
setup.pyconfirms 3.7 is incompatible:BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Successfully installing with 3.9
Succesfsfully installing with 3.8
Unsuccessfully installing with 3.7
TESTING INSTRUCTIONS
n/a
ADDITIONAL INFORMATION