fix(embedded): CSV download for chart

[lilykuang]

SUMMARY

CSV download didn't work

• move postForm to supersetClient
• add guest token to postForm
• check request form on get_guest_user_from_request for guest token

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #20261 (d7974f1) into master (f53018c) will decrease coverage by 11.75%.
The diff coverage is 84.61%.

@@             Coverage Diff             @@
##           master   #20261       +/-   ##
===========================================
- Coverage   66.70%   54.94%   -11.76%     
===========================================
  Files        1739     1739               
  Lines       65148    65150        +2     
  Branches     6897     6899        +2     
===========================================
- Hits        43457    35798     -7659     
- Misses      19938    27598     +7660     
- Partials     1753     1754        +1     

Flag	Coverage Δ
hive	53.69% <0.00%> (ø)
mysql	?
postgres	?
presto	53.55% <0.00%> (ø)
python	58.36% <0.00%> (-24.41%)	⬇️
sqlite	?
unit	50.53% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...erset-frontend/src/components/Chart/chartAction.js	55.92% <0.00%> (ø)
superset/security/manager.py	62.45% <0.00%> (-32.88%)	⬇️
...rset-ui-core/src/connection/SupersetClientClass.ts	97.82% <90.00%> (-2.18%)	⬇️
.../superset-ui-core/src/connection/SupersetClient.ts	100.00% <100.00%> (ø)
...re/components/controls/DatasourceControl/index.jsx	74.73% <100.00%> (ø)
...uperset-frontend/src/explore/exploreUtils/index.js	80.86% <100.00%> (+0.27%)	⬆️
superset/utils/dashboard_import_export.py	0.00% <0.00%> (-100.00%)	⬇️
superset/key_value/commands/upsert.py	0.00% <0.00%> (-89.59%)	⬇️
superset/key_value/commands/update.py	0.00% <0.00%> (-89.37%)	⬇️
superset/key_value/commands/delete.py	0.00% <0.00%> (-85.30%)	⬇️
... and 280 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f53018c...d7974f1. Read the comment docs.

[rusackas]

/testenv up

[github-actions]

@rusackas Ephemeral environment spinning up at http://54.185.245.155:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[justin-tomlinson]

Just checking if I understand this pull request correctly. Currently the CSV download option is not available in 1.5.0 when embedding using the sdk. I pulled master and enabled embedding and embedded in a test page and was able to see the option to download the csv from a chart, but selecting the download raised errors in the console about the iframe not having certain permissions (allow-forms, allow popups). Does this pull request correct issue allow user of an embedded dashboard to download the csv from charts?

[lilykuang]

@justin-tomlinson this PR will fix issue with downloading CSV but we need to add the allow-forms and allow popups permission to the SDK. I will open other PR to add these two permission to the SDK

[suddjian]

Looks good! Requested changes on some tests which I hope will be considered before a merge, but I feel good approving this.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.