docs: Added details to Druid connection string #20264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While linking Superset to Druid the correct connection string is very important however in the docs it is not well explained , so I added a little description to it
vincentkoc
approved these changes
Jun 5, 2022
srinify
requested changes
Jun 8, 2022
docs/docs/databases/druid.mdx
Outdated
| @@ -18,6 +18,7 @@ The connection string looks like: | |||
| ``` | |||
| druid://<User>:<password>@<Host>:<Port-default-9088>/druid/v2/sql | |||
| ``` | |||
| Where User and password are the credentials of your **Druid Database** , Host is your machine's IP address and Port is the port at which **Druid Database** is running. | |||
There was a problem hiding this comment.
Some quick feedback! It would be a bit more visually cleaner to turn this into a list:
"Here's a breakdown of the key parts of this connection string:
- User: username portion of the credentials needed to connect to your database
- Password: password portion of the credentials needed to connect to your database
- Host: IP address (or URL) of the host machine that's running your database
- Port: specific port that's exposed on your host machine where your database is running"
This way, we can also add this to the other database pages as well and it's a bit more generalized!
|
Hey @Neeraj-2307 quick comment / piece of feedback! |
eschutho
approved these changes
Jun 15, 2022
|
@srinify how does this look to you? |
srinify
approved these changes
Jun 17, 2022
|
Thanks for the contribution! |
akshatsri
pushed a commit
to charan1314/superset
that referenced
this pull request
Jul 19, 2022
* Added details to Druid connection string While linking Superset to Druid the correct connection string is very important however in the docs it is not well explained , so I added a little description to it * Update druid.mdx
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
While linking Superset to Druid the correct connection string is very important however in the docs it is not well explained , so I added a little description to it.