chore(dashboard): update Edit Dashboard side panel tabs #20337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Nice @codyml! I left some comments and tagged some wiki pages with common rules that we use 😉
superset-frontend/src/dashboard/components/BuilderComponentPane/BuilderComponentPane.test.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/BuilderComponentPane/BuilderComponentPane.test.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/BuilderComponentPane/index.tsx
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #20337 +/- ##
==========================================
+ Coverage 66.64% 66.67% +0.02%
==========================================
Files 1738 1738
Lines 65056 65056
Branches 6885 6885
==========================================
+ Hits 43356 43375 +19
+ Misses 19953 19935 -18
+ Partials 1747 1746 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/testenv up |
|
@michael-s-molina Ephemeral environment spinning up at http://54.185.222.195:8080. Credentials are |
michael-s-molina
approved these changes
Jun 10, 2022
codyml
force-pushed
the
codyml/sc-47191/default-to-charts-in-dashboard-edit-mode
branch
from
f6fe0c0
to
b1cb411
Compare
codyml
changed the title
codyml
deleted the
codyml/sc-47191/default-to-charts-in-dashboard-edit-mode
branch
|
Ephemeral environment shutdown and build artifacts deleted. |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Reorders/renames tabs for clarity, so Charts is first/default Components is instead named Layout Elements. Adds tests for
BuilderComponentPaneand relocates component and test files to meet file hierarchy recommendations.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TESTING INSTRUCTIONS
Unit test:
Note: despite passing, running test shows lots of console warning/errors – any idea why?
Manual check: check that clicking "Edit Dashboard" opens panel with Chart tab first and selected by default and Layout Elements tab second.
ADDITIONAL INFORMATION