fix: update connection modal to use existing catalog #20372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AAfghahi
previously approved these changes
Jun 14, 2022
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
Outdated
Show resolved
Hide resolved
AAfghahi
approved these changes
Jun 14, 2022
Codecov Report
@@ Coverage Diff @@
## master #20372 +/- ##
==========================================
- Coverage 66.64% 66.52% -0.13%
==========================================
Files 1738 1739 +1
Lines 65060 65143 +83
Branches 6885 6902 +17
==========================================
- Hits 43360 43336 -24
- Misses 19953 20054 +101
- Partials 1747 1753 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Jun 14, 2022
* fix: update connection modal to use existing catalog * remove console (cherry picked from commit 160e674)
|
🏷️ preset:2022.23 |
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Jun 14, 2022
* fix: update connection modal to use existing catalog * remove console (cherry picked from commit 160e674)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This pr fixes an issue when user hits finish on the dbconnection modal and is unable to exit the screen because parameters field is not sent when validating, causing an db error.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
after
Screen.Recording.2022-06-14.at.9.12.24.AM.mov
TESTING INSTRUCTIONS
Go to dbconnection modal for gsheets and enter in you creds. After hitting connect, clicking finish on the next step should exit the modal back to listview.
ADDITIONAL INFORMATION