Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cache warmup unable to login (#9597, #18933) #20387

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Merge branch 'master' into master

42b11f6
Select commit
Loading
Failed to load commit list.
Draft

fix: cache warmup unable to login (#9597, #18933) #20387

Merge branch 'master' into master
42b11f6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 30, 2025 in 0s

66.69% (-0.02%) compared to ccba5b2, passed because coverage increased by 0% when compared to adjusted base (66.68%)

View this Pull Request on Codecov

66.69% (-0.02%) compared to ccba5b2, passed because coverage increased by 0% when compared to adjusted base (66.68%)

Details

Codecov Report

Attention: Patch coverage is 78.57143% with 9 lines in your changes missing coverage. Please review.

Project coverage is 66.69%. Comparing base (ccba5b2) to head (42b11f6).
Report is 4775 commits behind head on master.

Files with missing lines Patch % Lines
superset/tasks/cache.py 54.54% 5 Missing ⚠️
superset/utils/screenshots.py 25.00% 3 Missing ⚠️
superset/utils/webdriver.py 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20387      +/-   ##
==========================================
- Coverage   66.70%   66.69%   -0.02%     
==========================================
  Files        1739     1739              
  Lines       65137    65121      -16     
  Branches     6897     6897              
==========================================
- Hits        43452    43433      -19     
- Misses      19932    19935       +3     
  Partials     1753     1753              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.