Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updated copy in chart drop down to "View as table" #20486

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

lauderbaugh
Copy link
Contributor

@lauderbaugh lauderbaugh commented Jun 23, 2022

SUMMARY

It said Drill to detail, which was misleading; instead it should say View as table since its just the table that creates the chart and not additional details.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screen Shot 2022-06-23 at 3 29 48 PM

After:

TESTING INSTRUCTIONS

Make sure it actually says the new copy. Test on ephem. env.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina changed the title Updated copy in chart drop down to "View as table" chore: Updated copy in chart drop down to "View as table" Jun 24, 2022
@zhaoyongjie zhaoyongjie self-requested a review June 24, 2022 15:30
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #20486 (77ce009) into master (661ab35) will not change coverage.
The diff coverage is n/a.

❗ Current head 77ce009 differs from pull request most recent head 97e2249. Consider uploading reports for the commit 97e2249 to get more accurate results

@@           Coverage Diff           @@
##           master   #20486   +/-   ##
=======================================
  Coverage   66.75%   66.75%           
=======================================
  Files        1740     1740           
  Lines       65156    65156           
  Branches     6900     6900           
=======================================
  Hits        43492    43492           
  Misses      19915    19915           
  Partials     1749     1749           
Flag Coverage Δ
javascript 51.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dashboard/components/SliceHeaderControls/index.tsx 64.28% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 661ab35...97e2249. Read the comment docs.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your first PR!

@rusackas rusackas merged commit 93fbfe9 into apache:master Jun 28, 2022
@kgabryje kgabryje added the v2.0 label Jun 30, 2022
michael-s-molina pushed a commit that referenced this pull request Jul 6, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v2.0 🍒 2.0.0 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants