-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Updated copy in chart drop down to "View as table" #20486
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov Report
@@ Coverage Diff @@
## master #20486 +/- ##
=======================================
Coverage 66.75% 66.75%
=======================================
Files 1740 1740
Lines 65156 65156
Branches 6900 6900
=======================================
Hits 43492 43492
Misses 19915 19915
Partials 1749 1749
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on your first PR!
(cherry picked from commit 93fbfe9)
SUMMARY
It said Drill to detail, which was misleading; instead it should say View as table since its just the table that creates the chart and not additional details.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
Make sure it actually says the new copy. Test on ephem. env.
ADDITIONAL INFORMATION