fix(big-number): big number gets cut off on a Dashboard #20488
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In the big number chart, we currently use
computeMaxFontSize
to measure the font size, where the incoming width is the actual width of the chart. After testing, it is found that the calculated font size has a certain error, resulting in truncation in the dashboard. So here we decrease 8px of the width to display fonts of different text lengths well.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Since the minimum font size is 10px, if the text length exceeds 12 in extreme cases, it will be truncated. So user need to resize chart at that moment.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION