-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add extension point to the top of welcome page #20575
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20575 +/- ##
=======================================
Coverage 66.79% 66.80%
=======================================
Files 1754 1754
Lines 65561 65577 +16
Branches 6933 6935 +2
=======================================
+ Hits 43793 43809 +16
Misses 20014 20014
Partials 1754 1754
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -95,6 +95,10 @@ export const URL_PARAMS = { | |||
name: 'viz_type', | |||
type: 'string', | |||
}, | |||
showDatabaseModal: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one of the setup guide step is to redirect to database list view and pop open the database modal
superset-frontend/packages/superset-ui-core/src/style/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/packages/superset-ui-core/src/ui-overrides/UiOverrideRegistry.ts
Outdated
Show resolved
Hide resolved
I removed the image asset since I believe that's meant to be part of the Preset feature, not part of Superset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sweet
* welcome top extension * show database modal * add test * Delete lines.svg * rename to banner * remove lines Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION