Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Published Dashboard without charts don't show up for non admin users #20638

Merged
merged 1 commit into from
Jul 27, 2022
Merged

fix: Published Dashboard without charts don't show up for non admin users #20638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion superset/dashboards/filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def apply(self, query: Query, value: Any) -> Query:

datasource_perm_query = (
db.session.query(Dashboard.id)
.join(Dashboard.slices)
.join(Dashboard.slices, isouter=True)
.filter(
and_(
Dashboard.published.is_(True),
Expand Down
2 changes: 1 addition & 1 deletion superset/sql_parse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ class InsertRLSState(str, Enum):

def has_table_query(token_list: TokenList) -> bool:
"""
Return if a stament has a query reading from a table.
Return if a statement has a query reading from a table.

>>> has_table_query(sqlparse.parse("COUNT(*)")[0])
False
Expand Down