Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(handlebars plugin): adding handlebars helpers for common math/formatting operations #20648

Merged
merged 3 commits into from
Jul 8, 2022

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Jul 8, 2022

SUMMARY

Adds the just-handlebars-helpers module to further expand the capabilities of the Handlebars viz plugin, allowing you to do common math operations and such in your templating

Hat tip to @villebro who did the real legwork on this long ago... I'm just making sure it gets into the codebase for all to enjoy :)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A - but the world is your oyster :)

TESTING INSTRUCTIONS

Just give it a whirl! On the ephemeral environment of this PR, or by building something fun on your own.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas rusackas requested a review from villebro July 8, 2022 04:26
@rusackas rusackas changed the title Handlebars helpers rebased feat(handlebars plugin): adding handlebars helpers for common math operations Jul 8, 2022
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #20648 (161c6ce) into master (e331640) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #20648      +/-   ##
==========================================
- Coverage   66.78%   66.78%   -0.01%     
==========================================
  Files        1754     1754              
  Lines       65857    65858       +1     
  Branches     7030     7030              
==========================================
  Hits        43982    43982              
- Misses      20086    20087       +1     
  Partials     1789     1789              
Flag Coverage Δ
hive 53.88% <ø> (ø)
javascript 51.93% <0.00%> (-0.01%) ⬇️
mysql 82.36% <ø> (ø)
postgres 82.43% <ø> (ø)
presto 53.74% <ø> (ø)
python 82.87% <ø> (ø)
sqlite 82.22% <ø> (ø)
unit 50.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ars/src/components/Handlebars/HandlebarsViewer.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e331640...161c6ce. Read the comment docs.

@rusackas rusackas merged commit 9856d88 into master Jul 8, 2022
@rusackas rusackas deleted the handlebars-helpers-rebased branch July 8, 2022 14:10
@rusackas rusackas changed the title feat(handlebars plugin): adding handlebars helpers for common math operations feat(handlebars plugin): adding handlebars helpers for common math/formatting operations Jul 8, 2022
akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
…erations (apache#20648)

* feat(plugin-chart-handlebars): add common helpers

* add import

* add declare module

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
@lilykuang lilykuang added the v2.0 label Feb 23, 2023
lilykuang pushed a commit to preset-io/superset that referenced this pull request Feb 23, 2023
…erations (apache#20648)

* feat(plugin-chart-handlebars): add common helpers

* add import

* add declare module

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
(cherry picked from commit 9856d88)
@ShadowA7X
Copy link

I'd like to highlight the addition of the just-handlebars-helpers module in this PR. This module, found here: https://github.com/leapfrogtechnology/just-handlebars-helpers, provides a comprehensive set of helpers which enhances the capabilities of the Handlebars plugin in Superset. Its integration will significantly extend the templating functionalities available in Superset's Handlebars plugin.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants