Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reports): Confirmation message after deleting reports #20753

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

Antonio-RiveroMartnez
Copy link
Member

SUMMARY

After deleting a report users would get stuck on with the modal open even after the report was actually deleted. It was caused because the resourceId was undefined when refreshing the data, so, we must use the chart info instead so the resourceId is not undefined

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
error

AFTER:
test

TESTING INSTRUCTIONS

  1. open a chart in explore and create report
  2. go to the manage report from 3 dot menu on top right in explore
  3. DELETE chart report

Expected Results:

  1. The modal closes after you click DELETE and the toast shows the success message
  2. The report is deleted

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

- dashboardInfo might be an empty object, in which case we must use the chart info instead so the resourceId is not undefined
@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #20753 (8f8ab6e) into master (92f3621) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 8f8ab6e differs from pull request most recent head d31f19f. Consider uploading reports for the commit d31f19f to get more accurate results

@@           Coverage Diff           @@
##           master   #20753   +/-   ##
=======================================
  Coverage   66.26%   66.26%           
=======================================
  Files        1754     1754           
  Lines       66678    66678           
  Branches     7049     7049           
=======================================
  Hits        44181    44181           
  Misses      20700    20700           
  Partials     1797     1797           
Flag Coverage Δ
javascript 51.92% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/reports/actions/reports.js 39.39% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92f3621...d31f19f. Read the comment docs.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit 07ce33d into apache:master Jul 27, 2022
@Antonio-RiveroMartnez Antonio-RiveroMartnez deleted the FIX-52713 branch August 2, 2022 21:15
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants