Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(csv): Do not coerce persisted data integer columns to float #20760

Merged
merged 6 commits into from
Jul 19, 2022
Merged

fix(csv): Do not coerce persisted data integer columns to float #20760

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cb7d25c
Replace pd.DataFrame.from_records with pd.DataFrame
john-bodley Jul 19, 2022
2915836
Remove unused code
john-bodley Jul 19, 2022
c6110c7
Update core.py
john-bodley Jul 19, 2022
2a4686e
Update core.py
john-bodley Jul 19, 2022
9ca2df2
Update csv.py
john-bodley Jul 19, 2022
4d2f439
Update core.py
john-bodley Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion superset/utils/csv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ def escape_value(value: str) -> str:


def df_to_escaped_csv(df: pd.DataFrame, **kwargs: Any) -> Any:
escape_values = lambda v: escape_value(v) if isinstance(v, str) else v

# Escape csv headers
df = df.rename(columns=escape_values)
Expand Down
9 changes: 7 additions & 2 deletions superset/views/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2502,8 +2502,13 @@ def csv( # pylint: disable=no-self-use,too-many-locals
obj = _deserialize_results_payload(
payload, query, cast(bool, results_backend_use_msgpack)
)
columns = [c["name"] for c in obj["columns"]]
df = pd.DataFrame.from_records(obj["data"], columns=columns)

df = pd.DataFrame(
data=obj["data"],
dtype=object,
columns=[c["name"] for c in obj["columns"]],
)

logger.info("Using pandas to convert to CSV")
else:
logger.info("Running a query to turn into CSV")
Expand Down