Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SqlLab): Change Save Dataset Button to Split Save Query Button IV #20852

Merged
merged 13 commits into from
Aug 1, 2022
Merged

feat(SqlLab): Change Save Dataset Button to Split Save Query Button IV #20852

merged 13 commits into from
Aug 1, 2022

Commits on Jul 29, 2022

  1. Moving entire split save btn PR

    @lyndsiWilliams
    lyndsiWilliams committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    c7ee008 View commit details
    Browse the repository at this point in the history

  2. Addressed review comments

    @lyndsiWilliams
    lyndsiWilliams committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    19f96c1 View commit details
    Browse the repository at this point in the history

  3. Remove arbitrary div from ErrorBoundary in Chart

    @lyndsiWilliams
    lyndsiWilliams committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    b370209 View commit details
    Browse the repository at this point in the history

  4. Added accidentally removed comment

    @lyndsiWilliams
    lyndsiWilliams committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    f66ce82 View commit details
    Browse the repository at this point in the history

  5. Fix act errors in SaveQuery tests

    @lyndsiWilliams
    lyndsiWilliams committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    5c3c9c2 View commit details
    Browse the repository at this point in the history

  6. Fix SaveDatasetActionButton test

    @lyndsiWilliams
    lyndsiWilliams committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    47b275d View commit details
    Browse the repository at this point in the history

  7. SaveDatasetModal test almost working

    @lyndsiWilliams
    lyndsiWilliams committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    4ed58bc View commit details
    Browse the repository at this point in the history

  8. SaveDatasetModal tests all passing

    @lyndsiWilliams
    lyndsiWilliams committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    c415fe4 View commit details
    Browse the repository at this point in the history

  9. Clean SaveDatasetModal test

    @lyndsiWilliams
    lyndsiWilliams committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    3fe3741 View commit details
    Browse the repository at this point in the history

  10. Fix create chart button and SaveDatasetModal text in SQL Lab

    @lyndsiWilliams
    lyndsiWilliams committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    da90320 View commit details
    Browse the repository at this point in the history

  11. Fix untitled dataset name on SaveDatasetModal in explore

    @lyndsiWilliams
    lyndsiWilliams committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    76375a8 View commit details
    Browse the repository at this point in the history

  12. Fix styling on split save button

    @lyndsiWilliams
    lyndsiWilliams committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    a8ef2ea View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. Merge branch 'master' of github.com:preset-io/superset into lyndsi/sp… 

    …lit-save-btn
    @lyndsiWilliams
    lyndsiWilliams committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    548c804 View commit details
    Browse the repository at this point in the history