Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide modal after overwrite #20924

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Jul 29, 2022

SUMMARY

close SaveDatasetModal on overwrite completion

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #20924 (0312394) into master (4d29d16) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #20924      +/-   ##
==========================================
- Coverage   66.31%   66.30%   -0.01%     
==========================================
  Files        1758     1758              
  Lines       67039    67065      +26     
  Branches     7116     7122       +6     
==========================================
+ Hits        44457    44468      +11     
- Misses      20752    20767      +15     
  Partials     1830     1830              
Flag Coverage Δ
javascript 52.01% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/src/SqlLab/components/SaveDatasetModal/index.tsx 34.88% <0.00%> (-0.42%) ⬇️
superset-frontend/src/utils/localStorageHelpers.ts 90.00% <0.00%> (ø)
.../explore/components/ExploreViewContainer/index.jsx 52.19% <0.00%> (ø)
...nd/src/explore/controlUtils/getSectionsToRender.ts 80.95% <0.00%> (+0.95%) ⬆️
...rset-frontend/src/explore/components/SaveModal.tsx 37.61% <0.00%> (+1.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@hughhhh hughhhh merged commit 67e3dc7 into apache:master Jul 29, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants