Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add timegrains to data payload #20938

Merged
merged 10 commits into from
Aug 4, 2022
Merged

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Aug 1, 2022

SUMMARY

Allow users to properly set time filter to update underlying query when chart source = Query

Screen Shot 2022-08-01 at 5 18 48 PM

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #20938 (f3e6848) into master (bfd2a3d) will decrease coverage by 0.03%.
The diff coverage is 16.27%.

❗ Current head f3e6848 differs from pull request most recent head bac0e81. Consider uploading reports for the commit bac0e81 to get more accurate results

@@            Coverage Diff             @@
##           master   #20938      +/-   ##
==========================================
- Coverage   66.38%   66.35%   -0.04%     
==========================================
  Files        1766     1766              
  Lines       67207    67251      +44     
  Branches     7129     7129              
==========================================
+ Hits        44617    44626       +9     
- Misses      20766    20801      +35     
  Partials     1824     1824              
Flag Coverage Δ
hive 53.15% <16.27%> (-0.05%) ⬇️
mysql 80.93% <16.27%> (-0.09%) ⬇️
postgres 81.00% <16.27%> (-0.09%) ⬇️
presto 53.05% <16.27%> (-0.05%) ⬇️
python 81.48% <16.27%> (-0.09%) ⬇️
sqlite 79.59% <16.27%> (-0.08%) ⬇️
unit 50.47% <11.62%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/models/helpers.py 39.71% <9.37%> (-1.08%) ⬇️
superset/models/sql_lab.py 77.01% <25.00%> (-1.74%) ⬇️
superset/common/query_context_processor.py 89.63% <66.66%> (-0.37%) ⬇️
superset/views/sql_lab.py 60.52% <0.00%> (ø)
superset/databases/schemas.py 98.59% <0.00%> (+<0.01%) ⬆️
superset/security/manager.py 95.39% <0.00%> (+0.01%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@yousoph
Copy link
Member

yousoph commented Aug 4, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

@yousoph Ephemeral environment spinning up at http://54.218.49.113:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@hughhhh hughhhh merged commit 6e5036d into apache:master Aug 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

Ephemeral environment shutdown and build artifacts deleted.

jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Aug 4, 2022
* add timegrains to data payload

* fix

* opps

* save

* integrate type casting for engiines

* add perm object

* change how wwe raise_for_access

* fix orderby on column types

* linting

(cherry picked from commit 6e5036d)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.31 size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants