Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-chart-echarts): missing value format in mixed timeseries #21044

Merged

Conversation

justinpark
Copy link
Member

SUMMARY

When we show values for a mixed time series chart (stacked bar + line chart), the value format won't be reflected in the values shown in the chart.
This commit updates mixed-timeseries' transformProps to include the missing formatter with dependent's attributes.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen Shot 2022-08-10 at 3 56 09 PM

After:

Screen Shot 2022-08-10 at 3 58 16 PM

TESTING INSTRUCTIONS

storybook

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@justinpark justinpark force-pushed the fix--echart-mixed-timeseries-invalid-format branch from 9de6700 to e63c41e Compare August 11, 2022 16:54
Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -82,8 +83,9 @@ export const Timeseries = ({ width, height }) => {
logAxis: boolean('Log axis', false),
xAxisTimeFormat: 'smart_date',
tooltipTimeFormat: 'smart_date',
yAxisFormat: 'SMART_NUMBER',
yAxisFormat: '$,.2f',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be a knob too? (either select or text)

@justinpark justinpark changed the title fix(plugin-echarts-mixed-timeseries): missing value format fix(plugin-chart-echarts): missing value format in mixed timeseries Aug 11, 2022
@justinpark justinpark force-pushed the fix--echart-mixed-timeseries-invalid-format branch from 47bc2b8 to 9bcf219 Compare August 11, 2022 18:30
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #21044 (9bcf219) into master (e13c5b2) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #21044      +/-   ##
==========================================
- Coverage   66.28%   66.27%   -0.01%     
==========================================
  Files        1770     1770              
  Lines       67497    67509      +12     
  Branches     7171     7177       +6     
==========================================
+ Hits        44738    44743       +5     
- Misses      20928    20932       +4     
- Partials     1831     1834       +3     
Flag Coverage Δ
javascript 52.00% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.00% <0.00%> (ø)
...d/plugins/plugin-chart-echarts/src/utils/series.ts 85.08% <0.00%> (-0.90%) ⬇️
...lugin-chart-echarts/src/Timeseries/transformers.ts 50.00% <0.00%> (-0.40%) ⬇️
...gin-chart-echarts/src/Timeseries/transformProps.ts 54.65% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ktmud ktmud merged commit 2d1ba46 into apache:master Aug 11, 2022
@justinpark justinpark deleted the fix--echart-mixed-timeseries-invalid-format branch August 11, 2022 19:40
justinpark added a commit to justinpark/superset that referenced this pull request Aug 11, 2022
john-bodley pushed a commit to airbnb/superset-fork that referenced this pull request Aug 17, 2022
Fahrenheit35 pushed a commit to Fahrenheit35/superset that referenced this pull request Nov 11, 2022
@mistercrunch mistercrunch added 🍒 2.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L v2.0 v2.0.1 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants