Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Dump clickhouse-sqlalchemy 0.2.2 #21195

Merged
merged 1 commit into from
Aug 25, 2022
Merged

chore: Dump clickhouse-sqlalchemy 0.2.2 #21195

merged 1 commit into from
Aug 25, 2022

Conversation

EugeneTorap
Copy link
Contributor

@EugeneTorap EugeneTorap commented Aug 25, 2022

Fix #19253 issue
Version 0.2.2 of clickhouse-sqlalchemy has resolved the problem - xzkostyan/clickhouse-sqlalchemy#180

#20325 & #19153 have been superseded by this PR.

SUMMARY

If you run any ClickHouse SQL with "format" keyword, returned results have no column headers, the first row of results will be the column header.

BEFORE SCREENSHOTS OR ANIMATED GIF

image

AFTER SCREENSHOTS OR ANIMATED GIF

image

TESTING INSTRUCTIONS

Run any ClickHouse SQL with "format" keyword like:

SELECT subtractDays(toDateTime(formatDateTime(now(),'%Y-%m-%d 00:00:00')),2) AS t

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@villebro villebro merged commit 994e1f6 into apache:master Aug 25, 2022
@EugeneTorap EugeneTorap deleted the chore/dump-clickhouse-sqlalchemy branch August 25, 2022 13:41
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python Issue leaks to SQL Lab when querying Clickhouse
4 participants