Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix act errors in DatasourceControl test #21426

Merged
merged 1 commit into from
Sep 10, 2022
Merged

test: Fix act errors in DatasourceControl test #21426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions ...set-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,20 +62,20 @@ const createProps = () => ({
onDatasourceSave: jest.fn(),
});

test('Should render', () => {
test('Should render', async () => {
const props = createProps();
render(<DatasourceControl {...props} />);
expect(screen.getByTestId('datasource-control')).toBeVisible();
expect(await screen.findByTestId('datasource-control')).toBeVisible();
});

test('Should have elements', () => {
test('Should have elements', async () => {
const props = createProps();
render(<DatasourceControl {...props} />);
expect(screen.getByText('channels')).toBeVisible();
expect(await screen.findByText('channels')).toBeVisible();
expect(screen.getByTestId('datasource-menu-trigger')).toBeVisible();
});

test('Should open a menu', () => {
test('Should open a menu', async () => {
const props = createProps();
render(<DatasourceControl {...props} />);

Expand All @@ -85,7 +85,7 @@ test('Should open a menu', () => {

userEvent.click(screen.getByTestId('datasource-menu-trigger'));

expect(screen.getByText('Edit dataset')).toBeInTheDocument();
expect(await screen.findByText('Edit dataset')).toBeInTheDocument();
expect(screen.getByText('Change dataset')).toBeInTheDocument();
expect(screen.getByText('View in SQL Lab')).toBeInTheDocument();
});
Expand Down Expand Up @@ -154,7 +154,7 @@ test('Edit dataset should be disabled when user is not admin', async () => {

userEvent.click(screen.getByTestId('datasource-menu-trigger'));

expect(screen.getByTestId('edit-dataset')).toHaveAttribute(
expect(await screen.findByTestId('edit-dataset')).toHaveAttribute(
'aria-disabled',
'true',
);
Expand All @@ -179,7 +179,7 @@ test('Click on View in SQL Lab', async () => {
expect(postFormSpy).toBeCalledTimes(1);
});

test('Should open a different menu when datasource=query', () => {
test('Should open a different menu when datasource=query', async () => {
const props = createProps();
const queryProps = {
...props,
Expand All @@ -196,12 +196,12 @@ test('Should open a different menu when datasource=query', () => {

userEvent.click(screen.getByTestId('datasource-menu-trigger'));

expect(screen.getByText('Query preview')).toBeInTheDocument();
expect(await screen.findByText('Query preview')).toBeInTheDocument();
expect(screen.getByText('View in SQL Lab')).toBeInTheDocument();
expect(screen.getByText('Save as dataset')).toBeInTheDocument();
});

test('Click on Save as dataset', () => {
test('Click on Save as dataset', async () => {
const props = createProps();
const queryProps = {
...props,
Expand All @@ -216,7 +216,7 @@ test('Click on Save as dataset', () => {
userEvent.click(screen.getByText('Save as dataset'));

// Renders a save dataset modal
const saveRadioBtn = screen.getByRole('radio', {
const saveRadioBtn = await screen.findByRole('radio', {
name: /save as new/i,
});
const overwriteRadioBtn = screen.getByRole('radio', {
Expand Down