Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix package name for Databricks dependency bundle #21448

Closed
wants to merge 1 commit into from

Conversation

danpicton
Copy link

SUMMARY

Instructions for Databricks database setup referred to the pre-Apache-Incubator superset repository superset[databricks]. Following this part of the current instructions results in a failed setup. This PR updates the reference to point to apache-superset[databricks].

TESTING INSTRUCTIONS

Failing workflow

  1. Add superset[databricks] to requirements/base.txt
  2. Build Superset from Dockerfile
  3. Launch built image with docker-compose

Successful workflow

  1. Add apache-superset[databricks] to requirements/base.txt
  2. Build Superset from Dockerfile
  3. Launch built image with docker-compose

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!

@rusackas
Copy link
Member

rusackas commented Feb 2, 2024

Looks like this was caught in #23562

Sorry this one slid under our collective radar... we appreciate this contribution nonetheless!!! Please feel free to tag committers here or ping us on Superset Slack if things get stuck like this.

@rusackas rusackas closed this Feb 2, 2024
@danpicton
Copy link
Author

danpicton commented Feb 2, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants