Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Color consistency E2E tests #21622

Merged
merged 37 commits into from
Oct 20, 2022
Merged

chore: Color consistency E2E tests #21622

merged 37 commits into from
Oct 20, 2022

Conversation

geido
Copy link
Member

@geido geido commented Sep 28, 2022

SUMMARY

E2E tests for color consistency in Dashboard. The CI should pass when the related PR is merged.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #21622 (cb3d5db) into master (f41d0b0) will decrease coverage by 11.26%.
The diff coverage is 59.75%.

❗ Current head cb3d5db differs from pull request most recent head 0db2623. Consider uploading reports for the commit 0db2623 to get more accurate results

@@             Coverage Diff             @@
##           master   #21622       +/-   ##
===========================================
- Coverage   66.82%   55.55%   -11.27%     
===========================================
  Files        1805     1805               
  Lines       69070    69070               
  Branches     7373     7373               
===========================================
- Hits        46159    38375     -7784     
- Misses      21005    28789     +7784     
  Partials     1906     1906               
Flag Coverage Δ
hive 52.92% <ø> (?)
mysql ?
postgres ?
presto 52.82% <ø> (ø)
python 57.94% <ø> (-23.33%) ⬇️
sqlite ?
unit 51.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-chart-controls/src/sections/advancedAnalytics.tsx 14.28% <ø> (ø)
...t-controls/src/sections/echartsTimeSeriesQuery.tsx 33.33% <ø> (ø)
...i-chart-controls/src/sections/forecastInterval.tsx 100.00% <ø> (ø)
...s/superset-ui-core/src/components/SafeMarkdown.tsx 66.66% <ø> (ø)
...ackages/superset-ui-core/src/query/types/Column.ts 100.00% <ø> (ø)
...d/packages/superset-ui-core/src/utils/isDefined.ts 100.00% <ø> (ø)
...legacy-plugin-chart-partition/src/controlPanel.tsx 25.00% <ø> (ø)
...gins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx 100.00% <ø> (ø)
...src/BigNumber/BigNumberWithTrendline/buildQuery.ts 0.00% <0.00%> (ø)
.../BigNumber/BigNumberWithTrendline/controlPanel.tsx 16.66% <ø> (ø)
... and 365 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@geido geido marked this pull request as ready for review October 4, 2022 14:06
@geido geido requested a review from jinghua-qa as a code owner October 4, 2022 14:06
@geido
Copy link
Member Author

geido commented Oct 4, 2022

Opening for an initial round of reviews. This PR will be rebased once the related color consistency PR will be merged

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@jinghua-qa jinghua-qa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geido geido merged commit b17ef18 into master Oct 20, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the chore/color-consistency-e2e branch March 26, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants