Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Race conditions with setupExtensions #21647

Merged
merged 2 commits into from
Oct 5, 2022
Merged

fix: Race conditions with setupExtensions #21647

merged 2 commits into from
Oct 5, 2022

Conversation

geido
Copy link
Member

@geido geido commented Sep 29, 2022

SUMMARY

Fixes an issue for which the setupExtensions would cause unwanted race conditions when extending components.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we get also get @eric-briscoe or @samtfm approval before merging it?

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have too many apps!!! But that's another problem. Thanks for this!!

@rusackas
Copy link
Member

We should probably rename superset/superset-frontend/src/profile/components/App.tsx if that's not yet another React app. It's a little disingenuous ;)

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #21647 (5478b30) into master (ab7cfec) will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #21647      +/-   ##
==========================================
+ Coverage   66.82%   66.87%   +0.04%     
==========================================
  Files        1798     1798              
  Lines       68781    68989     +208     
  Branches     7326     7403      +77     
==========================================
+ Hits        45962    46133     +171     
- Misses      20944    20964      +20     
- Partials     1875     1892      +17     
Flag Coverage Δ
hive 52.91% <ø> (ø)
javascript 53.30% <0.00%> (+0.15%) ⬆️
mysql 78.22% <ø> (ø)
postgres 78.29% <ø> (ø)
presto 52.81% <ø> (ø)
python 81.41% <ø> (ø)
sqlite 76.79% <ø> (ø)
unit 50.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (ø)
superset-frontend/src/preamble.ts 44.00% <ø> (-2.16%) ⬇️
superset-frontend/src/profile/App.tsx 0.00% <0.00%> (ø)
superset-frontend/src/views/App.tsx 0.00% <0.00%> (ø)
...nd/src/dashboard/components/gridComponents/Tab.jsx 82.41% <0.00%> (-1.26%) ⬇️
...ontend/src/dashboard/components/dnd/handleHover.js 9.09% <0.00%> (-0.91%) ⬇️
...d/src/dashboard/components/gridComponents/Tabs.jsx 80.58% <0.00%> (-0.67%) ⬇️
...s/legacy-plugin-chart-country-map/src/countries.ts 100.00% <0.00%> (ø)
...ntend/src/components/MetadataBar/ContentConfig.tsx 85.29% <0.00%> (+0.29%) ⬆️
.../explore/components/ExploreViewContainer/index.jsx 54.54% <0.00%> (+1.79%) ⬆️
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jinghua-qa jinghua-qa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deployed to a preset workspace and tested preset extension and feature flag related feature, did not find any issue. LGTM!

@geido geido merged commit de444d4 into master Oct 5, 2022
AnushaErrabelli pushed a commit to preset-io/superset that referenced this pull request Oct 5, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the fix/setupextensions branch March 26, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.39 size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants