Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: E2E Dashboards Cross-references #21805

Merged
merged 15 commits into from
Oct 21, 2022
Merged

Conversation

geido
Copy link
Member

@geido geido commented Oct 13, 2022

SUMMARY

Adds E2E tests for cross-referenced Dashboards in Charts list and Explore. Filtering was already tested in the original PR.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #21805 (289f72f) into master (b17ef18) will increase coverage by 1.24%.
The diff coverage is n/a.

❗ Current head 289f72f differs from pull request most recent head 0b0c3fe. Consider uploading reports for the commit 0b0c3fe to get more accurate results

@@            Coverage Diff             @@
##           master   #21805      +/-   ##
==========================================
+ Coverage   65.65%   66.90%   +1.24%     
==========================================
  Files        1806     1806              
  Lines       69130    69130              
  Branches     7391     7391              
==========================================
+ Hits        45390    46249     +859     
+ Misses      21829    20970     -859     
  Partials     1911     1911              
Flag Coverage Δ
javascript 53.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/components/ListView/CrossLinks.tsx 88.23% <ø> (ø)
...rontend/src/components/MetadataBar/MetadataBar.tsx 98.21% <ø> (ø)
superset/connectors/sqla/models.py 91.01% <0.00%> (+0.17%) ⬆️
superset/sql_lab.py 82.12% <0.00%> (+0.38%) ⬆️
superset/views/base_api.py 98.44% <0.00%> (+0.38%) ⬆️
superset/db_engine_specs/presto.py 87.78% <0.00%> (+0.40%) ⬆️
superset/db_engine_specs/__init__.py 85.71% <0.00%> (+1.19%) ⬆️
superset/datasets/schemas.py 97.40% <0.00%> (+1.29%) ⬆️
superset/commands/exceptions.py 93.84% <0.00%> (+1.53%) ⬆️
superset/initialization/__init__.py 91.46% <0.00%> (+2.04%) ⬆️
... and 49 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@geido geido marked this pull request as ready for review October 14, 2022 11:49
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the tests @geido!

Copy link
Member

@jinghua-qa jinghua-qa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geido geido merged commit 2fe68a3 into master Oct 21, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the chore/e2e-cross-references branch March 26, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants