Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: time grain key from P0.25Y to P3M #21919

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Oct 24, 2022

SUMMARY

The quarter identifier is P3M in the time grains instead of P0.25Y. This PR intends to fix this case in DuckDB, Tera Data, and Kusto.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie zhaoyongjie marked this pull request as ready for review October 24, 2022 08:27
@zhaoyongjie zhaoyongjie changed the title fix: time grain key from P0.25Y => P3M fix: time grain key from P0.25Y to P3M Oct 24, 2022
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #21919 (8cf5b9e) into master (9a063ab) will increase coverage by 11.11%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #21919       +/-   ##
===========================================
+ Coverage   55.55%   66.66%   +11.11%     
===========================================
  Files        1806     1806               
  Lines       69140    69141        +1     
  Branches     7393     7393               
===========================================
+ Hits        38409    46096     +7687     
+ Misses      28822    21136     -7686     
  Partials     1909     1909               
Flag Coverage Δ
hive ?
mysql 78.35% <ø> (?)
presto ?
python 80.96% <ø> (+23.02%) ⬆️
unit 51.07% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/duckdb.py 75.86% <ø> (ø)
superset/db_engine_specs/kusto.py 91.54% <ø> (ø)
superset/db_engine_specs/teradata.py 92.30% <ø> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/config.py 91.69% <0.00%> (+0.63%) ⬆️
superset/views/database/views.py 31.36% <0.00%> (+0.90%) ⬆️
superset/sql_parse.py 96.49% <0.00%> (+1.16%) ⬆️
superset/db_engine_specs/__init__.py 85.71% <0.00%> (+1.19%) ⬆️
superset/tables/models.py 67.53% <0.00%> (+1.29%) ⬆️
superset/exceptions.py 90.43% <0.00%> (+1.73%) ⬆️
... and 282 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll try to keep this in mind when reviewing new db engine specs in the future.

@zhaoyongjie zhaoyongjie merged commit c6c9215 into apache:master Oct 25, 2022
xneg added a commit to dodopizza/superset that referenced this pull request Mar 9, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants