fix: Change downloadAsImage to use Superset theme #22011
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR changes the background color of downloadAsImage to use the Superset theme. Originally, the value for this color was held in a local variable that referenced this line from our LESS variables file, but was assigned to the color
#F5F5F5
. Since that referenced color is now#d2edf4
in our LESS variables file, I referenced the matching color in our Superset theme instead (supersetTheme.colors.primary.light3
).BEFORE/AFTER SCREENSHOTS
I downloaded a chart as an image for both of these screenshots
BEFORE:
AFTER:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION