fix: allow datasource imports on Windows #22264
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
No sources are added when importing zip files on Windows, as file paths are parsed using
pathlib.PureWindowsPath
. Schemas are defined using prefixes with trailing slashes, therefore file paths in zipfiles should instead be treated aspathlib.PurePosixPath
s.Although Superset does not have official Windows support, this change fixes imports without changing the behaviour on Unix, since instantiating
pathlib.Path
creates apathlib.PurePosixPath
.TESTING INSTRUCTIONS
Import zipfile (e.g.
superset import_dashboards -p dashboard_export.zip
) on WIndows