-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DropdownContainer resize algorithm #22318
fix: DropdownContainer resize algorithm #22318
Conversation
/testenv up FEATURE_HORIZONTAL_FILTER_BAR=true |
@geido Ephemeral environment spinning up at http://34.222.85.66:8080. Credentials are |
Hey @michael-s-molina I think there is still might be an issue. I added a 4th filter and the "more filters" is showing up even though there would be space for it |
If you refresh the page, it shows? If not, then is because it doesn't fit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@geido I pushed another change. Let me see if you find anything. I'll wait for your review before merging the PR. |
Codecov Report
@@ Coverage Diff @@
## master #22318 +/- ##
==========================================
- Coverage 66.87% 66.86% -0.02%
==========================================
Files 1847 1847
Lines 70365 70395 +30
Branches 7718 7722 +4
==========================================
+ Hits 47057 47070 +13
- Misses 21309 21324 +15
- Partials 1999 2001 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes whatever weird thing was happening on my browser – resizing works great now! Thanks!
/testenv up FEATURE_HORIZONTAL_FILTER_BAR=true |
@geido Ephemeral environment spinning up at http://35.166.238.149:8080. Credentials are |
1 similar comment
@geido Ephemeral environment spinning up at http://35.166.238.149:8080. Credentials are |
Works great now! |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Fixes a bug in the
DropdownContainer
resize algorithm. Previously, the algorithm did not consider moving more than one element simultaneously when there was enough width available.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-12-02.at.11.07.38.AM.mov
Screen.Recording.2022-12-02.at.10.57.36.AM.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION