fix(snowflake): Allow encrypted_extra field to be imported #22357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The
encrypted_extra
field holds the keypair to authenticate to Snowflake. However, this field can't be imported currently.See #22348.
TESTING INSTRUCTIONS
Here are my test steps:
where
$url
is the sqlachemy URL andencrypted_extra
is the JSON encoded JSON block. So it looks something like this:superset import_datasources -p snowflake-import.yaml
dbs
table and verify that both the UI entry and the imported entry are identical.Prior to the fix, step 4 would fail. The
encrypted_extra
column would be empty for the imported entry.ADDITIONAL INFORMATION
Fixes #22348