fix: Button resizing in horizontal filter bar #22365
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Previously, the
DropdownContainer
only showed the badge count when the value was greater than zero. When the badge count was updated, the button would change its width to incorporate the badge count. That behavior could really impact user experience because the position of the button can totally change if that needed extra space ends up pushing another element to the popover. To resolve that, this PR always displays the badge count even if the value is zero.@kasiazjc Another possible solution would be to have more spacing between the button elements when there's no badge and less spacing when there's a badge. The important part would be to keep a constant button width. Let me know if you prefer that approach.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-12-07.at.4.52.58.PM.mov
TESTING INSTRUCTIONS
Check the video for instructions.
ADDITIONAL INFORMATION