-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Talisman configuration #22591
fix: Talisman configuration #22591
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22591 +/- ##
==========================================
+ Coverage 55.91% 65.48% +9.56%
==========================================
Files 1859 1859
Lines 71019 71020 +1
Branches 7766 7766
==========================================
+ Hits 39710 46504 +6794
+ Misses 29287 22494 -6793
Partials 2022 2022
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice if we could add a test to assert the config independence
(cherry picked from commit 84177cb)
(cherry picked from commit 84177cb)
SUMMARY
#21874 introduced a CSP check for production environments but ended up making the Talisman configuration dependent on the
CONTENT_SECURITY_POLICY_WARNING
key. This PR fixes this by loading Talisman values independently of the CSP warning.TESTING INSTRUCTIONS
1 - Play with Talisman configurations
2 - Check that the Talisman configurations are applied independently of the CSP warning
ADDITIONAL INFORMATION