chore: Migrate /superset/stop_query/ to API v1 #22624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22624 +/- ##
==========================================
- Coverage 66.88% 65.51% -1.38%
==========================================
Files 1859 1859
Lines 71103 71147 +44
Branches 7782 7782
==========================================
- Hits 47557 46610 -947
- Misses 21520 22511 +991
Partials 2026 2026
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
diegomedina248
force-pushed
the
dm/ch42050/migrate-superset-stop-query-to-api-v1
branch
from
c8b384f
to
601562f
Compare
dpgaspar
reviewed
Jan 9, 2023
superset/queries/dao.py
Outdated
|
|
||
| @staticmethod | ||
| def stop_query(client_id: str) -> None: | ||
| query = db.session.query(Query).filter_by(client_id=client_id).one() |
There was a problem hiding this comment.
an invalid client_id will raise, and the API would return HTTP 500, would be nicer to respond HTTP 404
|
|
||
| assert rv.status_code == 200 | ||
| data = json.loads(rv.data.decode("utf-8")) | ||
| assert data["result"] == "OK" |
There was a problem hiding this comment.
add one test for a non existent client_id
…h42050/migrate-superset-stop-query-to-api-v1
dpgaspar
approved these changes
Jan 16, 2023
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Continuing the effort on deprecating all /superset/ REST API endpoints
Deprecates /stop_query & moves is into api v1
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION