fix(nav): make doc and bug buttons customizable #22682
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently the documentation text and icon config parameters are not being respected in the
RightMenu
component. See the parameters here:superset/superset/config.py
Lines 1307 to 1310 in c0aeb2a
This fixes that + adds similar overrides for the bug links. In addition, the old right menu FAB template is no longer being used, and can hence be deleted.
AFTER
Here's the docs and buglinks with the new customizations (notice the top right hand corner next to "Settings"):
BEFORE
Previously the
DOCUMENTATION_ICON
andDOCUMENTATION_ICON
params weren't being used, and the bug link was not customizable:TESTING INSTRUCTIONS
ADDITIONAL INFORMATION