chore(welcome): harmonize submenu with other routes #22803
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The welcome page submenu currently does not use the same
SubMenu
component that's used on the other routes, like Dashboard, Chart, Dataset etc, causing it to deviate from the normal look and feel. This fixes that. At the same time I noticed that we were using a re-export ofFeatureFlag
from@superset-ui/core
in lots of places, which I believe is a remnant from the multirepo days. This removes the export and replaces all occurences with a direct import from@superset-ui/core
.AFTER
Now the Welcome page looks the same as the other pages:
BEFORE
Previously the "Home" text had a different font size, and the text next to the toggle was not using the proper theme.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION