-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Table sorting reset #23318
fix: Table sorting reset #23318
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23318 +/- ##
==========================================
+ Coverage 67.53% 67.56% +0.03%
==========================================
Files 1907 1907
Lines 73473 73475 +2
Branches 7976 7977 +1
==========================================
+ Hits 49617 49642 +25
+ Misses 21807 21785 -22
+ Partials 2049 2048 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works great!
SUMMARY
Fixes an issue for which the table would reset sorting when filtered. The sorting is now kept unless the columns of the Table change.
This PR also moves the most common hooks to superset-ui-core for reusability.
AFTER
Tables.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION