Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update typing for Table component #23398

Merged
merged 8 commits into from
Mar 20, 2023
Merged

chore: Update typing for Table component #23398

merged 8 commits into from
Mar 20, 2023

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Mar 16, 2023

SUMMARY

Replacement for #22832

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #23398 (f748d51) into master (870bf6d) will not change coverage.
The diff coverage is 75.00%.

❗ Current head f748d51 differs from pull request most recent head d2d15f6. Consider uploading reports for the commit d2d15f6 to get more accurate results

@@           Coverage Diff           @@
##           master   #23398   +/-   ##
=======================================
  Coverage   67.58%   67.58%           
=======================================
  Files        1907     1907           
  Lines       73530    73530           
  Branches     7980     7980           
=======================================
  Hits        49697    49697           
  Misses      21785    21785           
  Partials     2048     2048           
Flag Coverage Δ
javascript 53.82% <75.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/components/Chart/DrillDetail/DrillDetailPane.tsx 75.00% <ø> (ø)
.../dataset/AddDataset/EditDataset/UsageTab/index.tsx 90.47% <ø> (ø)
superset-frontend/src/components/Table/index.tsx 71.42% <60.00%> (ø)
...set-frontend/src/components/Table/VirtualTable.tsx 72.30% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hughhhh hughhhh changed the title Hugh/chore table chore: Update typing for Table component Mar 16, 2023
@hughhhh hughhhh merged commit 2fa8f98 into master Mar 20, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the hugh/chore-table branch March 26, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants