-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement context menu for drill by #23454
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23454 +/- ##
==========================================
- Coverage 67.65% 67.64% -0.01%
==========================================
Files 1910 1913 +3
Lines 73746 73838 +92
Branches 7987 8021 +34
==========================================
+ Hits 49891 49951 +60
- Misses 21814 21845 +31
- Partials 2041 2042 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
c7539e8
to
59587d0
Compare
de1c31f
to
d793393
Compare
/testenv up FEATURE_DRILL_BY=true FEATURE_DRILL_TO_DETAIL=true FEATURE_DASHBOARD_CROSS_FILTERS=true |
@geido Ephemeral environment spinning up at http://54.191.91.221:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested to work as expected, both with and without the FF. Since this is behind a FF I don't see any reason to not merge this as-is (if there are issues they will only affect users that have enabled the feature).
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Charts that support drill by: all Echarts, World Map, Table, Pivot Table.
This PR implements right-click context menu with drill by option for charts that support the feature. When user right-click on series, the chart plugin constructs a filter object (similar to drill to detail filter), which in the result chart will be appended to original chart's adhoc filters. Then, user can select a column from drill by submenu that later will be used as a dimension of the result chart.
The columns are fetched when user opens the context menu. The result is cached, so that the request is not repeated for charts that use the same dataset. Only columns that are marked as dimensions in the dataset and are not used as dimensions of current chart can be selected.
If there are more than 10 available columns, a search input in the submenu is displayed.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION